-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] - Create a Nebari Makefile for Local deployment and CI #2489
Comments
To ensure that the Makefile is always up-to-date, @dcmcand suggested using it in CI. Creating Makefile with steps followed in .github/workflows/test_local_integration.yaml would be an excellent place to start.
In later PRs, we can extend the same for other providers like GCP, DO, and AWS. For example: |
good point, @pt247; I was only considering including the playwright/cypress installation and test execution commands. But its a really neat idea to also incorporate the deploy/init structures. |
Let's use this issue as a super issue to track progress on Nebari Makefile sub-issues/tasks. |
Thanks @pt247, I was about to assign you to this as well 😄 |
Update: The following Git Gist contains the Makefile and the Nebari config I am using to create the Nebari cluster locally. https://gist.github.com/pt247/b17e3bec1dd25421082d109328a938b4 |
UpdateWith the above git gist, we can now spin up a local cluster for testing using the Makefile. The main issue with this setup is that it needs Cloudflare setup for usable certificates. There are requirements:
Some links worth exploring to find alternatives for Cloudflare: |
Limiting the scope of this ticketWe should focus on local certificates while we are working on #2238. |
Updated gist with the latest Makefile with playwright tests. |
This issue is still up for grabs. #2554 was closed as it had gotten stale, but can serve as a reference for future work |
Feature description
Currently, our tests GitHub Actions. Transitioning these installation workflows to a Makefile could alleviate some of the maintainers' burdens by simplifying the process of running tests locally. This move would streamline testing and potentially improve efficiency.
Value and/or benefit
Anything else?
No response
Tasks
The text was updated successfully, but these errors were encountered: