-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nebari upgrade tests #2701
Comments
@Adam-D-Lewis has provided a good direction, but to sumirize, basically: The main goal for this new test would be:
Some parts, like the "attest" final step, might seem ambiguous right now, so this can be discussed further. |
From an offline convo I had with @dcmcand:
The steps should be
Depending on the scope of the health checks, which we want to keep minimal for the initial version of this test, this might or might not detect whether the upgrade does not break anything. In any case, it will not be able to prevent the data loss described in the top comment that happened because a resource was deleted and recreated. To test that we would need to add some state in between step 1. and 2. above and verify its integrity after step 4. |
Context
Currently we have no automated deployment tests around running Nebari upgrade. Such a test would have prevented the data loss described in the context of #2700. This is also beneficial more broadly to help catch any error which occurs during the Nebari upgrade process, but not during an initial deployment. These tests should be added.
I propose the tests should upgrade from the last release of Nebari to the latest develop branch. You then check if files, conda envs, and users persisted across the upgrade.
We already have https://github.com/nebari-dev/nebari/blob/develop/.github/workflows/test_local_integration.yaml, https://github.com/nebari-dev/nebari/blob/develop/.github/workflows/test_aws_integration.yaml, https://github.com/nebari-dev/nebari/blob/develop/.github/workflows/test_azure_integration.yaml, https://github.com/nebari-dev/nebari/blob/develop/.github/workflows/test_gcp_integration.yaml as well as the deployment tests. These could be used as references when adding a nebari upgrade test.
The text was updated successfully, but these errors were encountered: