Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for arbitrary customization of terraform files #58

Closed
1 task
tylerpotts opened this issue Sep 21, 2020 · 3 comments
Closed
1 task

Allow for arbitrary customization of terraform files #58

tylerpotts opened this issue Sep 21, 2020 · 3 comments
Assignees
Labels
needs: discussion 💬 Needs discussion with the rest of the team

Comments

@tylerpotts
Copy link
Contributor

tylerpotts commented Sep 21, 2020

Currently, files need to be manually committed after running qhub-ops this is due to features that are not covered in the qhub configuration. We need an escape hook. This issue will require discussion on how we can achieve this.

  • Within quansight we will need to apply this solution to internal qhub clusters
@costrouc costrouc changed the title Fix the CI pipeline Allow for arbitrary customization of terraform files Sep 21, 2020
@costrouc costrouc added the needs: discussion 💬 Needs discussion with the rest of the team label Sep 21, 2020
@costrouc
Copy link
Member

The use cases:

  • extra permissions to conda-store
  • integration with prefect (needs to be a feature, issue is jupyterhub api token support)
  • docker image customization (add opencv package needed), jupyterhub extension toc

We need to account for these use cases to no longer freeze it

@prasunanand @aktech and I need to have a discussion. Balance as flexible as possible and opinionated. Long term terraform tdk is the solution.

@laisbsc
Copy link
Contributor

laisbsc commented Jan 7, 2021

Currently, this epic is waiting on a fix for the merge conflict on issue #76.
As soon as that is done, check if the team and close the issue.

@laisbsc laisbsc added needs: discussion 💬 Needs discussion with the rest of the team status: blocked and removed difficulty:medium labels Jan 25, 2021
@costrouc
Copy link
Member

Closing PR. We have talked as a team that we would like to use Terraform CDK #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 Needs discussion with the rest of the team
Projects
None yet
3 participants