[bug] qhub-deploy fails for azure project with dashes in the name

[TomAugspurger]

Describe the bug

qhub-deploy fails to deploy to Azure when using a project with dashes in the name. The error message is

[terraform]: Error: Failed to get existing workspaces: Error retrieving keys for Storage Account "qhub-test-tomdevtz9o1ryx": storage.AccountsClient#ListKeys: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="ResourceNotFound" Message="The Resource 'Microsoft.Storage/storageAccounts/qhub-test-tomdevtz9o1ryx' under resource group 'qhub-test-tom-dev' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"

A few pieces of information:

project name: qhub-test-tom.
stroage account postfix: tz9o1ryx.
storage account name: qhubtesttomdevtz9o1ryx

But in state.tf, we have

terraform {
  backend "azurerm" {
    resource_group_name = "qhub-test-tom-dev"
    # storage account must be globally unique
    storage_account_name = "qhub-test-tomdevtz9o1ryx"
    container_name       = "qhub-test-tom-devstate"
    key                  = "terraform/qhub-test-tom-dev.tfstate"
  }
}

The storage account has dashes in it (which I assume aren't allowed by Azure).

How can we help?

Help us help you.

• What are you trying to achieve?
• How can we reproduce the problem?
• What is the expected behaviour?
• And what is currently happening?
• Any error messages?

If helpful, please add any screenshots and relevant links to the description.

Your environment

Describe the environment in which you are experiencing the bug.

Include your conda version (use conda --version), k8s and any other relevant details.

$ conda list qhub
# packages in environment at /home/taugspurger/miniconda3/envs/qhub:
#
# Name                    Version                   Build  Channel
qhub                      0.3.11             pyhd8ed1ab_0    conda-forge

[viniciusdc]

Hi @TomAugspurger, thanks for using QHub. Azure has a number of constraints, which are implemented at different scopes, and must be considered while naming resources. Because of that, QHub currently uses some naming conventions to better address these outstanding restrictions.

[TomAugspurger]

Thanks. Would validating this be in scope for qhub?

[dharhas]

Yes it would.

[tarundmsharma]

@viniciusdc please updated the status on the issue.
Thank you

[viniciusdc]

Hi @TomAugspurger, sorry for the late feedback. This validation will be available in the next release, with validation messages to the end user to ensure the source of the error. Another feature that will be enhanced is a linter to help the user to verify the QHub config if you have github-action enabled.

Please let us know if we can help you with anything further, and thank you for using QHub.

[iameskild]

Hey @TomAugspurger, we apologize for the delay in getting to this! We are wrapping up a handful of PRs which address this (and other bugs). Thanks for you patience!

[iameskild]

Discussed internally. Update to #761 pending.