Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jupyterlab default environment part of managed nebari-config.yaml environments #785

Closed
1 task
tylerpotts opened this issue Aug 24, 2021 · 7 comments
Closed
1 task
Labels
needs: discussion 💬 Needs discussion with the rest of the team status: blocked ⛔️ This item is on hold due to another task type: enhancement 💅🏼 New feature or request

Comments

@tylerpotts
Copy link
Contributor

Summary

Currently the environment that jupyterlab launches with is built into the docker container that qhub launches with. This becomes an issue when users would like to modify the jupyterlab environment e.g. like PR #730. This would also reduce the size of the docker image speeding up the jupyterlab image launching.

Proposed implementation

The default jupyterlab environment will now be specified in DEFAULT_ENVIRONMENTS and the environment.yaml will be removed from the jupyterlab qhub image. There additionally needs to be a validation check to ensure that the default environment exists in the default environments.

Acceptance Criteria

  • jupyterlab profile should launch normally

Tasks to complete

Related to

Closes #715

@tylerpotts tylerpotts added type: enhancement 💅🏼 New feature or request good first issue Good for newcomers labels Aug 24, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because there was no recent activity in 60 days. Remove the stale label or add a comment, otherwise, this issue will automatically be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the status: stale 🥖 Not up to date with the default branch - needs update label Oct 25, 2021
@pierrotsmnrd pierrotsmnrd removed the status: stale 🥖 Not up to date with the default branch - needs update label Oct 25, 2021
@pierrotsmnrd
Copy link
Contributor

Useful feature. Let's keep this issue open.

@iameskild
Copy link
Member

Another related feature to consider is allowing users to install linux packages via qhub-config.yaml. Currently this handled in the Jupyterlab docker images (in apt.txt).

@trallard
Copy link
Member

trallard commented Dec 1, 2022

@iameskild does this need to remain open? seems this issue is now stale

@iameskild
Copy link
Member

iameskild commented Dec 1, 2022

@trallard I would say that if we go with the RFD I proposed here (or some other variant), we won't need this since the user will be able to customize their jupyterlab image how they see fit.

@trallard trallard added good first issue Good for newcomers status: blocked ⛔️ This item is on hold due to another task and removed good first issue Good for newcomers labels Dec 5, 2022
@trallard
Copy link
Member

trallard commented Dec 5, 2022

Ok marking as blocked until we decide on the RFD

@iameskild iameskild changed the title Make jupyterlab default environment part of managed qhub-config.yaml environments Make jupyterlab default environment part of managed nebari-config.yaml environments Sep 18, 2023
@dcmcand
Copy link
Contributor

dcmcand commented Feb 8, 2024

Closing because this is now possible using jhub-apps

@dcmcand dcmcand closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done 💪🏾 in QHub Project Mangement 🚀 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 Needs discussion with the rest of the team status: blocked ⛔️ This item is on hold due to another task type: enhancement 💅🏼 New feature or request
Projects
Development

No branches or pull requests

5 participants