Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qhub-config.yaml contents available within Kubernetes [enhancement] #902

Closed
danlester opened this issue Nov 4, 2021 · 3 comments · Fixed by #905
Closed

Make qhub-config.yaml contents available within Kubernetes [enhancement] #902

danlester opened this issue Nov 4, 2021 · 3 comments · Fixed by #905
Labels
type: enhancement 💅🏼 New feature or request

Comments

@danlester
Copy link
Contributor

Description

Create a configmap in kubernetes containing the qhub-config.yaml

Value/benefit

An extension I am writing needs to know all available jupyterlab profile names, i.e. within a pod. The qhub-config.yaml could be stored in a configmap and mounted on the pod.

I only really need profiles if we don't want everything in the yaml to be available - or we could mask certain secrets etc.

@danlester danlester added the type: enhancement 💅🏼 New feature or request label Nov 4, 2021
@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Nov 4, 2021

I wonder if this could be beneficial to the backup/restore solution. I like having this on k8s because it's sometimes possible for the deployed state to differ from what is in the qhub-config.yaml file (GitOps fails, if you aren't using GitOps, the state of the cluster while a redeploy is happening, etc.). I hadn't thought about potential secrets in the qhub config file much, but assumed we could use a configmap to store the qhub-config file in.

I believe our prefect integration requires a secret, but it's stored as an environment variable rather than in qhub-config.yaml so we should be good there.

@costrouc
Copy link
Member

costrouc commented Nov 4, 2021

I'd prefer that this is a Kubernetes secret. Reason being is that the qhub-config.yaml could have some sensitive information inside of it. Otherwise however I love this idea 😄

@danlester
Copy link
Contributor Author

Yes, it should be a secret. I don't think that changes anything much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants