Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Keycloak Client from jupyterhub_config.py.j2 [enhancement] #994

Closed
danlester opened this issue Jan 14, 2022 · 1 comment
Closed

Remove Keycloak Client from jupyterhub_config.py.j2 [enhancement] #994

danlester opened this issue Jan 14, 2022 · 1 comment
Labels
area: integration/keycloak type: enhancement 💅🏼 New feature or request

Comments

@danlester
Copy link
Contributor

Description

The jupyterhub_config.py.j2 file uses OAuth for login from Keycloak, but also fetches group and user info directly from keycloak via its own REST API. It doesn't need to do that because these details should be provided through userinfo in OAuth2, if configured correctly.

That would need to include showing group attributes so that profile lists are present.

Value/benefit

This will simplify the code, make it more secure and less likely to fall over. It will also speed things up.
@trallard trallard moved this to Needs Triage 🔍 in QHub Project Mangement 🚀 Jan 20, 2022
@costrouc
Copy link
Member

costrouc commented Feb 4, 2022

@danlester this was resolved with the #1003 PR. keycloak client is no longer used and userinfo is directly used.

@costrouc costrouc closed this as completed Feb 4, 2022
Repository owner moved this from Needs Triage 🔍 to Done 💪🏾 in QHub Project Mangement 🚀 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: integration/keycloak type: enhancement 💅🏼 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danlester @costrouc @trallard