Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Existing dashboards #1723

Merged
merged 9 commits into from
Apr 14, 2023
Merged

Fix Existing dashboards #1723

merged 9 commits into from
Apr 14, 2023

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 12, 2023 •
edited
Loading

Reference Issues or PRs

Closes #1127
Fixes Traefik, Keycloak, and Conda Store Dashboards

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title Fix dashboards Fix Existing dashboards Apr 13, 2023
@dharhas
Copy link
Member

dharhas commented Apr 13, 2023 •
edited by Adam-D-Lewis
Loading

Are there any graphs that show breakdown by user:

  • all the jupyter pods that are in use tagged by username
  • the dask workers tagged by username
  • argo pods tagged by user name
    etc

Most of that is in the other PR I've submitted recently. Here's a link: #1709

@iameskild
Copy link
Member

This is great, thanks @Adam-D-Lewis! My initial attempt at deploying this failed but I think it didn't include the most recent keycloak changes so I merged develop into your branch and I'll try again.

(Also just as an FYI, you might want to update your git config on your local machine, at the moment it looks like a blank user made these changes; see the black circle next to your commits. This happened to me earlier this year when I changed the email associated with GitHub)

@iameskild
Copy link
Member

/bot run tests

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Apr 13, 2023 •
edited
Loading

(Also just as an FYI, you might want to update your git config on your local machine, at the moment it looks like a blank user made these changes; see the black circle next to your commits. This happened to me earlier this year when I changed the email associated with GitHub)

Thanks for the heads up, @iameskild

iameskild
iameskild approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I was able to get it deployed on an existing cluster and played around with it for a bit.

I know that the conda-store admin panel tracks this as well (though perhaps not as accurately) but I was glad to see the conda-store volume storage amount here:
Screenshot 2023-04-13 at 16 16 47

Thanks @Adam-D-Lewis :)

@Adam-D-Lewis Adam-D-Lewis merged commit f590a03 into nebari-dev:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] - Adding Conda-Store, JupyterHub, Traefik, Keycloak Grafana Dashboards
3 participants
@Adam-D-Lewis @dharhas @iameskild