Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto match version to branch on deployment #9

Closed
naorlivne opened this issue Mar 4, 2019 · 1 comment
Closed

Auto match version to branch on deployment #9

naorlivne opened this issue Mar 4, 2019 · 1 comment

Comments

@naorlivne
Copy link
Member

Expected/Wanted Behaviour

The version of the SDK should be auto set to match the branches (and ignore the master branch as it's not the one that should be deployed from to PyPi but rather only valid numbered version branches).

the $TRAVIS_BRANCH envvar will likely be part of the solution but as this should be a change in the codebase itself (rather then just assigning the variable value a more complex solution the just os.getenv(TRAVIS_BRANCH) will be needed.

Possible solutions (need to read more about them):

Actual Behaviour

Version is manually set before deployments.

@naorlivne
Copy link
Member Author

closing in favor of #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant