Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Dockerfile based healthchecks #28

Closed
naorlivne opened this issue Nov 23, 2017 · 1 comment
Closed

Integrate with Dockerfile based healthchecks #28

naorlivne opened this issue Nov 23, 2017 · 1 comment

Comments

@naorlivne
Copy link
Member

Expected/Wanted Behavior

Nebula should integrate with Dockerfile based healthchecks so that if a container is defined as unhealthy it restarts it, it should default to on but have a per app flag that allows disabling that feature

It should be noted that if\when this will become included in the Docker engine it should really be used throughout that, either via Nebula passing Docker engine the needed settings or (hopefully) that becoming Docker engine default and means noting will be needed to be done Nebula side.

Actual Behavior

Currently Nebula\Docker engine only restarts crashed containers & ignores the Docker engine health checks results

@naorlivne
Copy link
Member Author

Pushed to latest, will be added to the next numbered release.

Due to new labels required to get this feature added this required making a semi-breaking change, while no API changed running the latest version while still having dangling work containers of an earlier version will result in a restart loop, the fix is to stop\kill & rm all work containers and let the new nebula version to recreate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant