Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ connections are not closed properly #31

Closed
naorlivne opened this issue Aug 2, 2018 · 1 comment
Closed

RabbitMQ connections are not closed properly #31

naorlivne opened this issue Aug 2, 2018 · 1 comment

Comments

@naorlivne
Copy link
Member

Similar to nebula-orchestrator/manager#16

Expected/Wanted Behavior

RabbitMQ connections should be closed whenever it's usage ends and it's attached channel is closed

Actual Behavior

Channel is closed but the connection is kept until it times out

How to fix

The rabbit_login function should also return the "rabbit_connection" & not just the "rabbit_connection_channel" and whenever the channel is closed explicitly it needs to close the connection as well.

@naorlivne
Copy link
Member Author

On further inspection connections are closed correctly in the worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant