Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py introduces modules that old and never used #6

Open
andelf opened this issue Jun 24, 2018 · 2 comments
Open

setup.py introduces modules that old and never used #6

andelf opened this issue Jun 24, 2018 · 2 comments

Comments

@andelf
Copy link

andelf commented Jun 24, 2018

sha3? where? (this is an old and nasty module that may conflicts with system hashlib)
pycurl? where?
pysha3? where?
toolz? where?

also you seemed write Python in Java style. 🤣

@andelf
Copy link
Author

andelf commented Jun 24, 2018

You copied setup.py from another unrelated project?

@yupnano
Copy link
Contributor

yupnano commented Jun 26, 2018

Thank you for the feedback, it's true that this api sdk is influenced by Java. It's welcome if you want to improve it.

I have removed the sha3, and uploaded it again to PyPI as neb-py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants