Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report.omit not working with relative_files #1521

Open
gaborbernat opened this issue Jan 2, 2023 · 3 comments
Open

report.omit not working with relative_files #1521

gaborbernat opened this issue Jan 2, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@gaborbernat
Copy link
Contributor

gaborbernat commented Jan 2, 2023

When doing pypa/virtualenv#2477 I noticed that with relative_files report.omit seems no longer active. See failing run https://github.com/pypa/virtualenv/actions/runs/3824948711/jobs/6507540653, while before turning relative files on here https://github.com/pypa/virtualenv/actions/runs/3821105582/jobs/6499921063 seems to still work.

The config file is here: https://github.com/gaborbernat/virtualenv/blob/fix/pyproject.toml#L96-L112

@gaborbernat gaborbernat added bug Something isn't working needs triage labels Jan 2, 2023
@nedbat
Copy link
Owner

nedbat commented Jan 3, 2023

Hmm, it looks like a relative omit pattern like 'src/whatever/*.py' won't work with relative_files=true. You can make it work for now with a pattern of '*/src/whatever/*.py' while I figure out the implications of a change...

@gaborbernat
Copy link
Contributor Author

Your workaround worked perfectly, so I adopted that for now.

@thejcannon
Copy link

As a data point, I believe this worked when we were using version 6.5. So it might be a regression between those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants