Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running tests on Windows #16

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Conversation

kurtmckee
Copy link
Contributor

Hi Ned, this fixes two problems that I encountered.

First, it resolves hard-coded '/' directory separators in the unit tests -- on Windows these appear as backslashes, and now the unit tests should be flexible enough to allow for this.

Second, it explicitly specifies the directories for Black to scan. In my environment I set up a virtual environment, and Black spent a long time scanning every Python file in the virtual environment. I've separated the changes in case you don't want this change included.

Please let me know if you have any questions or want something changed or done a different way.

tests/test_config.py Outdated Show resolved Hide resolved
@kurtmckee
Copy link
Contributor Author

Rebased on master now that #17 is merged.

@nedbat
Copy link
Owner

nedbat commented Dec 14, 2020

Thanks! In the future, I might come up with a more succinct way to deal with the os.path.sep thing, but this is good for now!

@nedbat nedbat merged commit b366370 into nedbat:master Dec 14, 2020
@kurtmckee kurtmckee deleted the windows-tests branch December 14, 2020 14:14
@kurtmckee
Copy link
Contributor Author

Thanks Ned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants