Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple clang failed tautological-compare #2

Open
nega0 opened this issue Feb 2, 2019 · 0 comments
Open

apple clang failed tautological-compare #2

nega0 opened this issue Feb 2, 2019 · 0 comments
Assignees
Labels
compiler tag for compiler differences or issues

Comments

@nega0
Copy link
Owner

nega0 commented Feb 2, 2019

This is fixed on trunk.

// Predicate for tm equality
static bool tmEq(struct tm const& t1, struct tm const& t2) {
return t1.tm_sec == t2.tm_sec && t1.tm_min == t2.tm_min &&
t1.tm_hour == t2.tm_hour && t1.tm_mday == t1.tm_mday &&
t1.tm_mon == t2.tm_mon && t1.tm_year == t2.tm_year;
}

Apple clang missed the self-compare of t1.tm_mday, here. Need to do one or more of:

  • confirm llvm/clang catches it
  • reformat so apple/clang and/or llvm/clang catches it
  • make a local test case (really?)
  • make a test case to send upstream
@nega0 nega0 added the compiler tag for compiler differences or issues label Feb 2, 2019
@nega0 nega0 self-assigned this Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler tag for compiler differences or issues
Projects
None yet
Development

No branches or pull requests

1 participant