fix: short sha has at least four digits (#2540)

ChristopherHX · mergify[bot] · web-flow · commit b4ef6fb482e1 · 2024-12-24T21:33:13.000Z
Currently it is not very unlikly to have a false match for tag `0` with sha `0XXXXXXXXXXXXXXXXXXXXXXX`, 1 to 16

Co-authored-by: mergify[bot] &lt;37929162+mergify[bot]@users.noreply.github.com&gt;
diff --git a/pkg/common/git/git.go b/pkg/common/git/git.go
@@ -330,7 +330,7 @@ func NewGitCloneExecutor(input NewGitCloneExecutorInput) common.Executor {
 			logger.Errorf("Unable to resolve %s: %v", input.Ref, err)
 		}
 
-		if hash.String() != input.Ref && strings.HasPrefix(hash.String(), input.Ref) {
+		if hash.String() != input.Ref && len(input.Ref) >= 4 && strings.HasPrefix(hash.String(), input.Ref) {
 			return &Error{
 				err:    ErrShortRef,
 				commit: hash.String(),

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ func NewGitCloneExecutor(input NewGitCloneExecutorInput) common.Executor {`
`330`	`330`	`logger.Errorf("Unable to resolve %s: %v", input.Ref, err)`
`331`	`331`	`}`
`332`	`332`
`333`		`- if hash.String() != input.Ref && strings.HasPrefix(hash.String(), input.Ref) {`
	`333`	`+ if hash.String() != input.Ref && len(input.Ref) >= 4 && strings.HasPrefix(hash.String(), input.Ref) {`
`334`	`334`	`return &Error{`
`335`	`335`	`err: ErrShortRef,`
`336`	`336`	`commit: hash.String(),`