Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

act shouldn't complain when there's no remote repo #2493

Open
stephenwithav opened this issue Oct 19, 2024 · 3 comments · May be fixed by #2495
Open

act shouldn't complain when there's no remote repo #2493

stephenwithav opened this issue Oct 19, 2024 · 3 comments · May be fixed by #2495
Labels
kind/feature-request New feature or request

Comments

@stephenwithav
Copy link

stephenwithav commented Oct 19, 2024 •
edited
Loading

Act version

5a1e0d9, built with my PR

Feature description

act complains when there's no remote repo.

Sometimes, a dev just wants to test ideas locally before creating a remote repo. :)

act/pkg/model/github_context.go

Line 172 in ccd28e7

common.Logger(ctx).Warningf("unable to get git repo (githubInstance: %v; remoteName: %v, repoPath: %v): %v", githubInstance, remoteName, repoPath, err) 

func (ghc *GithubContext) SetRepositoryAndOwner(ctx context.Context, githubInstance string, remoteName string, repoPath string) {
	if ghc.Repository == "" {
		repo, err := git.FindGithubRepo(ctx, repoPath, githubInstance, remoteName)
		if err != nil {
			common.Logger(ctx).Warningf("unable to get git repo (githubInstance: %v; remoteName: %v, repoPath: %v): %v", githubInstance, remoteName, repoPath, err)
			return
		}
		ghc.Repository = repo
	}
	ghc.RepositoryOwner = strings.Split(ghc.Repository, "/")[0]
}
@stephenwithav stephenwithav added the kind/feature-request New feature or request label Oct 19, 2024
@stephenwithav
Copy link
Author

This used to work but was removed.

https://github.com/nektos/act/compare/9085c833bf2b68e90c022e70912b3c0c4499bdbc..ace4cd47c7f099864866b1f60e064fecde7f36ea#diff-c057d66dc9657d8428e290c69871596e2b567bb8fecad62a99cab54398131a84L679

@stephenwithav
Copy link
Author

The main issue is getGithubContext is called in multiple places, so the error repeats over and over.

@stephenwithav stephenwithav linked a pull request Oct 19, 2024 that will close this issue
Open
@stephenwithav
Copy link
Author

This bypasses the remote warning introduced in #2169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable "unable to get git repo" when none exists. stephenwithav/act
1 participant
@stephenwithav