Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add copy-on-write overlay mount method option #676

Open
JustinGrote opened this issue May 7, 2021 · 2 comments
Open

Enhancement: Add copy-on-write overlay mount method option #676

JustinGrote opened this issue May 7, 2021 · 2 comments
Assignees
Labels
area/runner Relating to errors in the runner kind/feature-request New feature or request stale-exempt Exempt from stale

Comments

@JustinGrote
Copy link
Contributor

Describe feature

Currently the two options are to bind or mount volumes to work with data, or copy data into the container.

Bind is risky because it is read-write and if you do an action like checkout, you will blow away your data.

Copying data, especially with a large repository, can be slow to create and may produce a large temp file.

I would like to propose a third option, which is to read-only bind the folder and add a read-write overlay mount to tmpfs (Reference: https://stackoverflow.com/a/54465442/5511129). This results in an "instant" mount of the data but allows changes to occur in multiple containers simultaneously without actually changing the local data like bind does.

Preliminary tests on both Windows and Linux show this working really well and I'm happy to PR if tagged up-for-grabs.

This option is also ideal for non-root container scenarios implemented in #666

@JustinGrote JustinGrote added the kind/feature-request New feature or request label May 7, 2021
@JustinGrote JustinGrote changed the title Enhancement: Use overlay Enhancement: Add copy-on-write overlay mount method option May 7, 2021
@ukd1
Copy link

ukd1 commented May 22, 2021

I'm also having issues with this, as I have a project with a gbs of data in git-lfs, which takes a while to copy.

@catthehacker catthehacker self-assigned this May 22, 2021
@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runner Relating to errors in the runner kind/feature-request New feature or request stale-exempt Exempt from stale
Projects
None yet
Development

No branches or pull requests

3 participants