-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TracyClient.cpp compile error on Windows #4
Comments
Would it be feasible to point zig-tracy to that exact commit, and then fix any discrepancies that come up? That way we fix the issue while still pointing to a fixed Tracy version, even if it means requiring Tracy to be built from source by the user. We could also wait for another major Tracy release but it's been a while since that's happened. |
are most people building tracy from source? if they're no longer making tags i could remove the version pin |
does |
mingw but zig cc allows both either mingw and msvc at the user's request |
Ah! As luck would have it Tracy 0.8 just released. So pointing at that version should fix the issue |
The author of tracy fixed this compilation error here
wolfpld/tracy#260
Not sure how you could fix it for zig-tracy since that one depends on the tracy 0.7.8 release.
Applying the fix locally works though.
The text was updated successfully, but these errors were encountered: