Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracyClient.cpp compile error on Windows #4

Open
SentientNr6 opened this issue Jan 22, 2022 · 5 comments
Open

TracyClient.cpp compile error on Windows #4

SentientNr6 opened this issue Jan 22, 2022 · 5 comments

Comments

@SentientNr6
Copy link

The author of tracy fixed this compilation error here
wolfpld/tracy#260

Not sure how you could fix it for zig-tracy since that one depends on the tracy 0.7.8 release.

Applying the fix locally works though.

@cheeze42
Copy link

Would it be feasible to point zig-tracy to that exact commit, and then fix any discrepancies that come up? That way we fix the issue while still pointing to a fixed Tracy version, even if it means requiring Tracy to be built from source by the user. We could also wait for another major Tracy release but it's been a while since that's happened.

@nektro
Copy link
Owner

nektro commented Feb 19, 2022

are most people building tracy from source? if they're no longer making tags i could remove the version pin

@cheeze42
Copy link

does zig cc still use mingw? Because apparently Tracy has since deprecated support for mingw entirely, according to their changelog, so it's possible that there would be issues using the latest tracy master.

@nektro
Copy link
Owner

nektro commented Feb 22, 2022

mingw but zig cc allows both either mingw and msvc at the user's request

@cheeze42
Copy link

Ah! As luck would have it Tracy 0.8 just released. So pointing at that version should fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants