Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting python >= 3.7 #34

Open
nick-youngblut opened this issue Jan 3, 2024 · 1 comment
Open

Supporting python >= 3.7 #34

nick-youngblut opened this issue Jan 3, 2024 · 1 comment

Comments

@nick-youngblut
Copy link

According to https://github.com/nel-lab/FIOLA/blob/master/setup.py, the package supports Python >= 3.7, but it appears that https://github.com/nel-lab/FIOLA/blob/master/requirements.txt is set so strictly that only Python 3.8 is actually supported, and the setup instructions in the README also suggest this:

git clone https://github.com/nel-lab/FIOLA.git
git clone https://github.com/flatironinstitute/CaImAn.git -b v1.9.13
cd FIOLA
conda create --name fiola python==3.8
conda activate fiola
pip install -r requirements.txt 
pip install -e.
cd ../CaImAn
pip install -e . 

Lastly, there appears to be no CI/CD testing (e.g., via GitHub actions) of various python versions to show that Python >= 3.7 is actually supported.

Given that Python 3.8 is rather old and not supported by some platforms (e.g., Terra-Bio), it would be helpful to include more support for other Python versions.

@raymondwjang
Copy link

Seconding @nick-youngblut. Tensorflow, Numpy, Pandas seem to have all dropped Python 3.8 support, so installing it is actually becoming impossible just by following the steps listed on README.md.

conda create --name fiola python==3.8 needs to be replaced by a conda-forge channel via conda create --name fiola python=3.8 -c conda-forge

pip install -r requirements.txt with pip version 24.2 also throws ERROR: No matching distribution found for tensorflow==2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants