Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve is_valid_in_api check for InitialWaterlevels #196

Open
daanvaningen opened this issue Jul 8, 2022 · 2 comments
Open

Improve is_valid_in_api check for InitialWaterlevels #196

daanvaningen opened this issue Jul 8, 2022 · 2 comments

Comments

@daanvaningen
Copy link
Contributor

Currently save_to_api for initial waterlevel is able to run while initial waterlevel might not be uploaded: https://github.com/nens/threedi-api/issues/1672. This creates issues in making of simulation templates. Improve the is_valid_in_api function to make this more robust.
@Jonasvsl
Copy link

Jonasvsl commented Jan 5, 2023

is this the correct repo for this ticket?

@daanvaningen
Copy link
Contributor Author

Yes, the simulation template creation stuff is in the modelchecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jonasvsl @daanvaningen