Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up generic checks #406

Open
2 tasks
margrietpalm opened this issue Oct 16, 2024 · 0 comments
Open
2 tasks

Clean up generic checks #406

margrietpalm opened this issue Oct 16, 2024 · 0 comments

Comments

@margrietpalm
Copy link
Contributor

Before the upgrade several checks were created based on attributes of the columns:

  • ForeignKeyCheck (0001) for all columns with foreign_keys
  • UniqueCheck (0002) for all columns with unique or primary_key
  • NotNullCheck (0003) for all columns with nullable

Except for id and geom columns, these checks are no longer automatically generated and some may have been missed. Furthermore, the ones that are there are scattered.

Tasks:

  • List which columns should be covered in checks 1, 2 and/or 3 (based on docs for 219)
  • Collect and add these in one and only one place in config.py (consider using a separate file to create these lists for easy maintainance)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant