Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker: pipe & culvert connections #57

Open
caspervdw opened this issue Jun 15, 2021 · 3 comments
Open

Checker: pipe & culvert connections #57

caspervdw opened this issue Jun 15, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@caspervdw
Copy link
Contributor

caspervdw commented Jun 15, 2021

The invert levels of pipes and culverts should not differ more than their cross section height.

Unless if there is storage on the node.

@caspervdw caspervdw self-assigned this Oct 4, 2021
@caspervdw caspervdw added the enhancement New feature or request label Feb 16, 2022
@Jonasvsl
Copy link

(Nici) : warning if there is a big difference, calculation points need to be added

@Jonasvsl
Copy link

Jonasvsl commented Jan 5, 2023

As I see it we have two choices:

  • Solve this for the user by automatically adding more calculation points and warn the user about the situation
  • Give an error with the advice to add more calculation points on these culverts / pipes

I'm in favor of the first option as this is what users will want in most cases, unless there is a typo in the invert level or a dutch situation where people sometimes forget a minus

@caspervdw
Copy link
Contributor Author

I don't understand the comments by @nvolp and @Jonasvsl ; if the invert levels differ more than the cross section height, the addition of nodes will not make a difference. Please explain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants