Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match sqlite table names to ORM classes #119

Open
margrietpalm opened this issue Oct 14, 2024 · 2 comments
Open

Match sqlite table names to ORM classes #119

margrietpalm opened this issue Oct 14, 2024 · 2 comments
Assignees

Comments

@margrietpalm
Copy link
Contributor

margrietpalm commented Oct 14, 2024

Names of sqlite tables and classes in the ORM do not all match properly after the migration. For consistency it would make sense to change this sucht that the names match.

This involves the following tables and dependencies

Current class name sqlite table name new class name modelchecker grid-builder api calculation-core
ControlMeasureLocation measure_location MeasureLocation ✔️ ✔️
ControlMeasureMap measure_map MeasureMap ✔️ ✔️ ✔️
ControlMemory memory_control MemoryControl ✔️ ✔️ ✔️
ControlTable table_control TableCotnrol ✔️ ✔️ ✔️
VegetationDrag vegetation_drag_2d VegetationDrag2D ✔️ ✔️ ✔️
Windshielding windshielding_1d Windshielding1D ✔️ ✔️ ✔️
SurfaceParameter surface_parameters SurfaceParameters ✔️ ✔️ ✔️
Lateral1d lateral_1d Lateral1D ✔️ ✔️ ✔️
VegetationDrag vegetation_drag_2d VegetationDrag2D ✔️ ✔️ ✔️
@margrietpalm margrietpalm self-assigned this Oct 14, 2024
@margrietpalm
Copy link
Contributor Author

@daanvaningen I see that this involves the calculation core so I'd like your opinion on whether to do this or not.

@daanvaningen
Copy link
Contributor

If this will just mean changing some table names when we read in the sqlite then I am not too worried :) My assessment is that it will have minimal impact so go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants