Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gridbuilder - 1D schema upgrade #389

Open
6 of 10 tasks
margrietpalm opened this issue Oct 14, 2024 · 0 comments
Open
6 of 10 tasks

gridbuilder - 1D schema upgrade #389

margrietpalm opened this issue Oct 14, 2024 · 0 comments
Assignees

Comments

@margrietpalm
Copy link
Contributor

margrietpalm commented Oct 14, 2024

  • Adapt interface/db.py do changes in column names
  • Remove reading of manholes and modify reading of mahole related fields from ConnectionNodes
  • Remove reading of CrossSectionDefinition and directly read cross section parameters from
    • CrossSectionLocation: cross_section_shape, cross_section_width, cross_section_height, cross_section_table, cross_section_friction_values, cross_section_vegetation_table
    • Culvert, Orifce, Pipe, and Weir: cross_section_shape, cross_section_width, cross_section_height, cross_section_table,
  • Process new field: ModelSettings.node_open_water_detection:

Setting should affect the behaviour of threedigrid_builder.grid.connection_nodes.ConnectionNodes.is_closed(). If node_open_water_detection = 1, use the current method. If it is 0, connection nodes that have >= channels connected to them should be regarded as "open water", i.e. is_closed() returns False

  • Process new obstacle fields:
    • Obstacle.affects_2d:

If True, the exchange level (dpumax) of 2D-2D flowlines that are intersected by this obstacle are increased to the obstacle's crest level

  • Obstacle.affects_1d2d_open_water:

If True, the exchange level (dpumax) of 1D-2D flowlines from "open water" nodes to 2D that are intersected by this obstacle are increased to the obstacle's crest level

  • Obstacle.affects_1d2d_closed:

If True, the exchange level (dpumax) of 1D-2D flowlines from "closed" nodes (i.e. sewerage and culverts) to 2D that are intersected by this obstacle are increased to the obstacle's crest level

@margrietpalm margrietpalm self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant