Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal toString() calls should include InvariantCulture #466

Closed
robinabganpat opened this issue Jan 16, 2021 · 0 comments · Fixed by #467
Closed

Decimal toString() calls should include InvariantCulture #466

robinabganpat opened this issue Jan 16, 2021 · 0 comments · Fixed by #467

Comments

@robinabganpat
Copy link
Contributor

Describe the bug
Currently on systems with an European culture is set not using the InvariantCulture might result in Decimal.ToString() to result in something like: "123,45" instead of "123.45". This then results in a parsing error when using in BigDecimal.Parse() for example.

To Reproduce
Steps to reproduce the behavior:

  1. Set your system's culture to something like 'nl-NL' (so your system's decimal becomes a comma).
  2. Run a project which uses the RPC Server (for example: neo-express).
  3. See error logging for format exception.

Expected behavior
Independent of the culture of the system where NEO projects are ran, parsing should work as expected.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform:

  • OS: Windows 10 x64
  • Version: v3.0.0-preview4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant