Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationLogs and RpcNep17Tracker should not depend on LevelDB #614

Open
devhawk opened this issue Jul 22, 2021 · 6 comments
Open

ApplicationLogs and RpcNep17Tracker should not depend on LevelDB #614

devhawk opened this issue Jul 22, 2021 · 6 comments

Comments

@devhawk
Copy link
Contributor

devhawk commented Jul 22, 2021

StateStore doesn't take a dependency on LevelDB, instead it loads an IStore instance from the NeoSystem instance:

public StateStore(StatePlugin system, string path)
{
    if (singleton != null) throw new InvalidOperationException(nameof(StateStore));
    this.system = system;
    this.store = StatePlugin.System.LoadStore(path);
    singleton = this;
    StatePlugin.System.ActorSystem.EventStream.Subscribe(Self, typeof(Blockchain.RelayResult));
    UpdateCurrentSnapshot();
}

Can we update ApplicationLogs and RpcNep17Tracker to work this way?

@gsmachado
Copy link

@superboyiii @devhawk any news about this issue?

This makes it very challenging (not to say impossible) to use rocksdb.

@gsmachado
Copy link

Either we come up with a config in the node level to specify which DB it should use, OR each plugin should have a config to change the DB.

@devhawk
Copy link
Contributor Author

devhawk commented Dec 6, 2021

The new token tracker plugin works like state store. So it's just app logs that still has this issue

@gsmachado
Copy link

is this still an issue? gosh.....

@gsmachado
Copy link

So... should we close this one?

Reference: #761

@cschuchardt88
Copy link
Member

PR #807 depends on IStore, Hope this fixes issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants