Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support getcontractstate by ID for non-native contracts #788

Closed
roman-khimov opened this issue Jan 13, 2023 · 0 comments · Fixed by #813
Closed

Support getcontractstate by ID for non-native contracts #788

roman-khimov opened this issue Jan 13, 2023 · 0 comments · Fixed by #813
Labels
discussion

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
#378 has added support for getcontractstate requests using native contract IDs/names (see #355 and #339 as well). Back when it had been implemented there was no way to map ID to contract hash for non-native contracts, now after neo-project/neo#2807 solving neo-project/neo#2803 it is easily possible to do that.

Do you have any solution you want to propose?
Add logic to allow getcontractstate to operate with IDs for non-native contracts. NeoGo supports this since 0.92.0 and we can finally unify behavior of this call.

Where in the software does this update applies to?

  • RPC (HTTP)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RpcServer: added GetContractState by contract id support cschuchardt88/neo-modules
1 participant
@roman-khimov