Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found bug in UT_ProtocolSettings #1484

Closed
Tommo-L opened this issue Mar 17, 2020 · 2 comments
Closed

Found bug in UT_ProtocolSettings #1484

Tommo-L opened this issue Mar 17, 2020 · 2 comments

Comments

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 17, 2020

Describe the bug

UT_ProtocolSettings is not reliable and often executes failure on github action.

image

Here is an example

Platform:

  • Github Action
@Tommo-L Tommo-L changed the title Fix bug in UT_ProtocolSettings Found bug in UT_ProtocolSettings Mar 17, 2020
@Qiao-Jin Qiao-Jin mentioned this issue Apr 3, 2020
Closed
@Tommo-L Tommo-L closed this as completed Apr 3, 2020
@Tommo-L Tommo-L reopened this Apr 23, 2020
@Tommo-L
Copy link
Contributor Author

Tommo-L commented Apr 23, 2020

Still exists

image

https://github.com/neo-project/neo/pull/1593/checks?check_run_id=607609321

@Qiao-Jin Qiao-Jin mentioned this issue Apr 27, 2020
Merged
@devhawk
Copy link
Contributor

devhawk commented Apr 27, 2020

ProtocolSettings.Initialize tests cannot be run in parallel w/ tests that implicitly initialize ProtocolSettings.Default. More details here: #1616 (comment)

@shargon shargon closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove UT_ProtocolSettings from culture test to avoid test failure by design Qiao-Jin/neo
3 participants
@devhawk @shargon @Tommo-L