Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a network identifier argument in sign method #1503

Closed
Tommo-L opened this issue Mar 23, 2020 · 0 comments · Fixed by #1550
Closed

Add a network identifier argument in sign method #1503

Tommo-L opened this issue Mar 23, 2020 · 0 comments · Fixed by #1550
Labels
Discussion Initial issue state - proposed but not yet accepted
Milestone

Comments

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 23, 2020

Summary or problem description
We have noticed that two transactions on different networks are exactly the same, because
the transactions between Mainnet and Testnet do not identify the destination network. Thus,
there is the possibility of reusing the same transaction between the two networks.

Do you have any solution you want to propose?
A successful solution would be to include the network identifier in the transaction signature
and in all signed messages, in this way we will create signed payloads uniquely and
exclusively for each network. (See EIP-155 3 )

Pseudocode

Signature = Sign(PrivateKey, Concat(NetworkMagic, Message))

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • Wallets

original posted by @Red4Sec

@Tommo-L Tommo-L added the Discussion Initial issue state - proposed but not yet accepted label Mar 23, 2020
@erikzhang erikzhang added this to the NEO 3.0 milestone Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants