Why does ApplicationEngine.Run default to test mode?

[devhawk]

Prior to #1819, ApplicationEngine.Run testMode parameter defaulted to false. Now, the gas parameter defaults to TestModeGas.

Wouldn't it make more sense to default gas parameter to zero? Or remove the default entirely?

[Tommo-L]

Or remove the default entirely?

Agree.

[shargon]

Yes, I think that we can remove the default value.

[Tommo-L]

As this method, how about renaming TestModeGas to DefaultGas or setting it zero?

neo/src/neo/SmartContract/ApplicationEngine.cs

Line 290 in b4daa6d

public static ApplicationEngine Run(byte[] script, StoreView snapshot = null, IVerifiable container = null, Block persistingBlock = null, int offset = 0, long gas = TestModeGas)

[erikzhang]

Because in most cases we use test mode.

[Qiao-Jin]

I think we should use wallet balance instead of testmodegas, as in common sense the one who tests executing script locally will send corresponding transaction. Furthermore, a 20 gas testmodegas might not be enough for some cases.

[superboyiii]

I think we should use wallet balance instead of testmodegas, as in common sense the one who tests executing script locally will send corresponding transaction. Furthermore, a 20 gas testmodegas might not be enough for some cases.

But this means you'll always return fault if you don't open your wallet when execution. It doesn't make sense. Virtual resource cost should not be the same value of actual wallet balance. If like that, you always need open wallet and have enough gas.