Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'name' method in native contracts #2102

Closed
roman-khimov opened this issue Nov 25, 2020 · 0 comments · Fixed by #2103
Closed

'name' method in native contracts #2102

roman-khimov opened this issue Nov 25, 2020 · 0 comments · Fixed by #2103
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
NEP-17 removed name() method requirement and #2024 brought Name field to manifests for native contracts. Still, native contracts keep name() method exposed to other smart contracts.

Do you have any solution you want to propose?
I think we can remove it now from public contract's methods (the field Name of course is still useful, it just shouldn't be a ContractMethod).

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • Native contracts
@roman-khimov roman-khimov added the discussion Initial issue state - proposed but not yet accepted label Nov 25, 2020
@shargon shargon mentioned this issue Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove name method from native contract shargon/neo
1 participant
@roman-khimov