Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards should be 'calculated' instead of being provided by users #2125

Closed
lock9 opened this issue Dec 7, 2020 · 2 comments
Closed

Standards should be 'calculated' instead of being provided by users #2125

lock9 opened this issue Dec 7, 2020 · 2 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@lock9
Copy link
Contributor

lock9 commented Dec 7, 2020

Summary or problem description
We have smart contracts that affirm that they implement a certain standard, but the implemented methods differ in practice. For example, balanceOf, instead of returning an integer, returns a byte array. This breaks infra-structure tools that expect the standard to be followed. Smart contracts may 'break' too if they expect a type and get another instead. It is worth saying that interfaces enforce method signatures in any programming language (must be identical to the one in the interface).
TL;DR: Some smart contracts are not following the standards correctly. How can we avoid that?

Do you have any solution you want to propose?
The standards should be 'calculated' when the smart contract is deployed to the network instead of being provided by the user (checking the ABI).

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • Ledger
  • Network Policy
@lock9 lock9 added the Discussion Initial issue state - proposed but not yet accepted label Dec 7, 2020
@roman-khimov
Copy link
Contributor

See #1883 also.

@lock9
Copy link
Contributor Author

lock9 commented Dec 7, 2020

@roman-khimov I will close this one and support your issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants