Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional parameter to _deploy method #2238

Closed
roman-khimov opened this issue Jan 15, 2021 · 0 comments · Fixed by #2239
Closed

Additional parameter to _deploy method #2238

roman-khimov opened this issue Jan 15, 2021 · 0 comments · Fixed by #2239
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
Some contracts require initialization before their first real use and we have _deploy method now to run at deployment/update stage. But some contracts need to get an additional data for proper initialization (hashes of other contracts, addresses of admins, other data, https://github.com/nspcc-dev/neofs-contract/blob/c6fd4dc77c3aab3795057eb3fae2a7946285f3c5/alphabet/alphabet_contract.go#L59 for example) and we can't pass it at the moment to the _deploy thus an additional initialization transaction is still needed.

Do you have any solution you want to propose?
Add an additional StackItem data parameter to Deploy (and Update?) method of ManagementContract and pass it to _deploy callback.

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • Other: ManagementContract
@roman-khimov roman-khimov added the Discussion Initial issue state - proposed but not yet accepted label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant