Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logs to Blockchain.ApplicationExecuted #2992

Open
cschuchardt88 opened this issue Nov 24, 2023 · 0 comments
Open

Add Logs to Blockchain.ApplicationExecuted #2992

cschuchardt88 opened this issue Nov 24, 2023 · 0 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 24, 2023

Summary or problem description
Trying to get all LogEventArgs for a transaction. Will emit logs twice. Reason being, is when a user send a invokescript or invokefunction to a node it will emit the log twice for ApplicationEngine.Log event. Because one for the invokescript and one for adding the transaction (if valid). The only way to get the logs is by hooking on to ApplicationEngine.Log. Since the transaction state isn't known either way. No way of knowing whether the transaction is one that is getting committed or not.

Reference: neo-project/neo-modules#807 (comment)

So process goes like this:
Wallet.MakeTransaction() will do a test invoke on the node and see if transaction is valid than will send the transaction on the network, in turn will commit the transaction (if valid). Seeing how LogEventArgs only has three properties ScriptContainer, Message and Contract. It will be the same transaction hash for both Wallet.MakeTransaction() and the committing transaction on the block.

Do you have any solution you want to propose?
Add Logs to Blockchain.ApplicationExecuted

Neo Version

  • Neo 3.6.2

Where in the software does this update applies to?

  • Core
@cschuchardt88 cschuchardt88 added the Discussion Initial issue state - proposed but not yet accepted label Nov 24, 2023
@shargon shargon added Node and removed Node labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants