Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dockerfile for neo-cli to run and test basic functionalities #3256

Closed
2 of 4 tasks
vncoelho opened this issue May 21, 2024 · 5 comments
Closed
2 of 4 tasks
Assignees
Labels
Consensus Module - Changes that affect the consensus protocol or internal verification logic Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Feature Type: Large changes or new features Unit Tests

Comments

@vncoelho
Copy link
Member

vncoelho commented May 21, 2024

Now that we have all necessary features in this repo, it is CRUCIAL to build and run a neo-cli client on EVERY commit and PULL REQUEST.

In this sense, as in the past, a good way to do that is to use a dockerfile and a script that initializes the client and test some functionalities such as consensus, wallet, among others.

In the past we have done that using screen command.
Thus, the first PRs will go in this direction.

This issue will be further updated to split the task into different parts.

  • Create a dockerfile that can build and run a neo-cli (can be dealt aligned with Improve devcontainer to dockerfile #3255)
  • Improve dockerfile or create a new one
  • Create a folder with scripts that can initialize just run a client and verify if it has been initialized without a crash - use expect Return expect to verify neo-cli #3318
  • Do some CI with devcontainer in order to ensure local development is working with generic paths
@vncoelho
Copy link
Member Author

@cschuchardt88 , I am counting with you on this!

@vncoelho vncoelho added Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Feature Type: Large changes or new features Consensus Module - Changes that affect the consensus protocol or internal verification logic Unit Tests labels May 21, 2024
@vncoelho
Copy link
Member Author

@cschuchardt88, perhaps that devcontainer CI will be great for now.

Here is the documentation https://github.com/devcontainers/ci

@vncoelho
Copy link
Member Author

https://github.com/devcontainers/ci/blob/main/docs/github-action.md

@cschuchardt88
Copy link
Member

cschuchardt88 commented May 23, 2024

I looked into everything, And read all docs. Its best to go with a github action workflow for this. One big reason is we don't have the storage for this. Also I ready did github actions for neo-express.

https://github.com/neo-project/neo-express/blob/ff3bf4f444d137d89b15d6c914497b765cae3b8b/.github/workflows/test.yml#L66-L99

@cschuchardt88
Copy link
Member

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consensus Module - Changes that affect the consensus protocol or internal verification logic Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Feature Type: Large changes or new features Unit Tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants