-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend getversion
RPC response with additional protocol settings
#3401
Comments
Some of these values comes from |
I forgot about it, NeoGo has everything in a single configuration. Can we live with this dependency? Or another solution may be to move |
If it's from DBFTPlugin's configuration, it means that they won't be essential for validating the block by normal nodes. Which also means that Therefore, I'm not sure if it's a good idea to expose those settings to others. |
I am in favor of living without the dependency for now. |
|
Summary or problem description
Some dApp developers face the necessity to restore blockchain using settings from
protocol
section ofgetversion
RPC response without additional knowledge about node configuration. I discovered that this section doesn't contain the following protocol settings:MaxBlockSize
MaxBlockSystemFee
StandbyCommittee
SeedList
Without
StandByCommittee
it's impossible to restore blockchain. WithoutMaxBlockSystemFee
andMaxBlockSize
it's impossible to properly verify blocks and/or transactions. WithoutSeedList
it's impossible to sync the network.I see that there's a need for these settings to be included into
getversion
response, it would be beneficial for Dora Explorer back-end development.Do you have any solution you want to propose?
Extend
protocol
section ofgetversion
RPC response with these protocol parameters.MaxBlockSize
,MaxBlockSystemFee
andStandbyCommittee
are a must-have from my PoW, whereasSeedList
is a matter of discussion.It's easy to implement, but I'd like to collect some more opinions on this topic before the modification. If we agree, then I'll implement it.
Where in the software does this update applies to?
The text was updated successfully, but these errors were encountered: