Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minCommunitySize to non-LPA community detection algorithms #243

Closed
6 of 8 tasks
FlorentinD opened this issue Jan 18, 2023 · 6 comments
Closed
6 of 8 tasks

Add minCommunitySize to non-LPA community detection algorithms #243

FlorentinD opened this issue Jan 18, 2023 · 6 comments
Labels
feature request A suggestion for a new feature good first issue Indicates a good issue for first-time contributors

Comments

@FlorentinD
Copy link
Contributor

FlorentinD commented Jan 18, 2023

Is your feature request related to a problem? Please describe.

For Label Propagation and Louvain, we added the minCommunitySize to its write mode (example).

Describe the solution you would like

Additionally the minCommunitySize parameter could be exposed to:

  • Triangle Count
  • K1-coloring
  • ModularityOptimization
  • Approximate Maximum k-cut
  • Leiden
  • WCC.stream (as minComponentSize)
  • Louvain.stream
  • LabelPropagation.stream

Additional context

The logic for the minComponentSize|minCommunitySize is contained inside the CommunityProcCompanion.

If you want to work on this issue please drop a comment :)

@FlorentinD FlorentinD added feature request A suggestion for a new feature good first issue Indicates a good issue for first-time contributors labels Jan 18, 2023
@airtyon
Copy link
Contributor

airtyon commented Jan 21, 2023

hey @FlorentinD, I would like to give this one a try. I will ask here if I have any questions.

@airtyon
Copy link
Contributor

airtyon commented Jan 27, 2023

hey @FlorentinD, will the new attributes be added to the stream & write mode of the listed algorithms(except the last 2 items) or just to the write mode? if it's the latest, I noticed that Approximate Maximum k-cut, doesn't a write mode.
thank you.

@FlorentinD
Copy link
Contributor Author

Hey @airtyon ,
I would say we can also add it to the stream modes.
If you like, you could also just do the write modes and we can adjust the checklist to reflect what is left after your PR :)

Thanks for picking this up!

@airtyon
Copy link
Contributor

airtyon commented Feb 3, 2023

hey @FlorentinD,
I completed the write mode for the algorithms listed above, I have some doubts regarding Triangle Count & K1-coloring.

the reason I am commenting is that after adding minCommunitySize to Louvain in stream mode and afterwards trying to extends the tests and altering the value of minCommunitySize; I didn't see any change in the final output.

it is obvious that I have a knowledge gap somewhere but I can't pinpoint it.

I hope what I wrote makes sense.

@FlorentinD
Copy link
Contributor Author

Hey @airtyon ,
Great to hear you could make progress!

How about you create a draft pull request with what you currently have?
Then it's easier to help you :)

@airtyon
Copy link
Contributor

airtyon commented Feb 3, 2023

@FlorentinD draft PR : #245
thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion for a new feature good first issue Indicates a good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants