-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minCommunitySize
to non-LPA community detection algorithms
#243
Comments
hey @FlorentinD, I would like to give this one a try. I will ask here if I have any questions. |
hey @FlorentinD, will the new attributes be added to the stream & write mode of the listed algorithms(except the last 2 items) or just to the write mode? if it's the latest, I noticed that Approximate Maximum k-cut, doesn't a write mode. |
Hey @airtyon , Thanks for picking this up! |
hey @FlorentinD, the reason I am commenting is that after adding minCommunitySize to Louvain in stream mode and afterwards trying to extends the tests and altering the value of minCommunitySize; I didn't see any change in the final output. it is obvious that I have a knowledge gap somewhere but I can't pinpoint it. I hope what I wrote makes sense. |
Hey @airtyon , How about you create a draft pull request with what you currently have? |
@FlorentinD draft PR : #245 |
Is your feature request related to a problem? Please describe.
For Label Propagation and Louvain, we added the
minCommunitySize
to its write mode (example).Describe the solution you would like
Additionally the
minCommunitySize
parameter could be exposed to:minComponentSize
)Additional context
The logic for the
minComponentSize|minCommunitySize
is contained inside theCommunityProcCompanion
.If you want to work on this issue please drop a comment :)
The text was updated successfully, but these errors were encountered: