Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .nvmrc to use 'lts/gallium' #1921

Open
luchillo17 opened this issue Jun 3, 2023 · 4 comments · May be fixed by #1922
Open

Update .nvmrc to use 'lts/gallium' #1921

luchillo17 opened this issue Jun 3, 2023 · 4 comments · May be fixed by #1922

Comments

@luchillo17
Copy link

Description

Installing with nvm install uses the .nvmrc version, which is currently set to 16.10.0, this gives errors when installing.

Reproduce Steps

  • Have Python >=3.10
  • Clone the repository with a node version installed other than 16.10.0 or without any installed,
  • Run nvm install on the root folder.

Expected Behavior

Nvm installs Node without any issues.

Current Behavior

Errors out complaining about Python 3.10

2023-06-03_02h52_38

Can you propose a solution?

I would recommend changing this to the LTS version lts/gallium or at least updating to 16.20.0.

Your Environment

image

software name version
OS Windows 10 WSL2 Ubuntu
Web browser Chrome
node.js None before install
npm -
yarn -
Neo4j Browser Cloned repo master branch
Neo4j -

Additional Information

The Readme mentions Node v12, we should update that as well.

@luchillo17 luchillo17 linked a pull request Jun 3, 2023 that will close this issue
@OskarDamkjaer
Copy link
Contributor

I didn't know the installation could break by having python installed, interesting! We used to have a later version of 16, but I remember there was some issue with either jest or similar. Ideally we'd move to node 18, since it's the latest LTS. I'll investigate

Thanks for taking the time to report this issue and add a solution!

@OskarDamkjaer
Copy link
Contributor

Ah yes here it was #1820

@luchillo17
Copy link
Author

Hmm then maybe it's better to mention the specific Python version limit until that gets fixed?

@OskarDamkjaer
Copy link
Contributor

I think the best would be to both update node and migrate away from webpack & jest to vite and vitest, but I don't think we well do that anytime soon. Mentioning the python issue is better than nothing in the mean time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants