Make eligible field final and refactor throws (#1452)

Author: injectives

bundle/pom.xml

@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.neo4j.driver</groupId>
     <artifactId>neo4j-java-driver-parent</artifactId>
-    <version>5.10-SNAPSHOT</version>
+    <version>5.11-SNAPSHOT</version>
     <relativePath>..</relativePath>
   </parent>
 

driver/pom.xml

@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.neo4j.driver</groupId>
     <artifactId>neo4j-java-driver-parent</artifactId>
-    <version>5.10-SNAPSHOT</version>
+    <version>5.11-SNAPSHOT</version>
   </parent>
 
   <artifactId>neo4j-java-driver</artifactId>

driver/src/main/java/org/neo4j/driver/internal/cluster/SingleDatabaseRoutingProcedureRunner.java

@@ -51,7 +51,7 @@ public class SingleDatabaseRoutingProcedureRunner implements RoutingProcedureRun
     static final String GET_ROUTING_TABLE = "CALL dbms.cluster.routing.getRoutingTable($" + ROUTING_CONTEXT + ")";
 
     final RoutingContext context;
-    private Logging logging;
+    private final Logging logging;
 
     public SingleDatabaseRoutingProcedureRunner(RoutingContext context, Logging logging) {
         this.context = context;

driver/src/main/java/org/neo4j/driver/internal/logging/NettyLogging.java

@@ -26,7 +26,7 @@
  * This is the logging factory to delegate netty's logging to our logging system
  */
 public class NettyLogging extends InternalLoggerFactory {
-    private Logging logging;
+    private final Logging logging;
 
     public NettyLogging(Logging logging) {
         this.logging = logging;

driver/src/main/java/org/neo4j/driver/internal/packstream/PackStream.java

@@ -151,7 +151,7 @@ public class PackStream {
     private PackStream() {}
 
     public static class Packer {
-        private PackOutput out;
+        private final PackOutput out;
 
         public Packer(PackOutput out) {
             this.out = out;
@@ -337,7 +337,7 @@ public void packStructHeader(int size, byte signature) throws IOException {
     }
 
     public static class Unpacker {
-        private PackInput in;
+        private final PackInput in;
 
         public Unpacker(PackInput in) {
             this.in = in;

driver/src/main/java/org/neo4j/driver/internal/summary/InternalDatabaseInfo.java

@@ -22,7 +22,7 @@
 import org.neo4j.driver.summary.DatabaseInfo;
 
 public class InternalDatabaseInfo implements DatabaseInfo {
-    public static DatabaseInfo DEFAULT_DATABASE_INFO = new InternalDatabaseInfo(null);
+    public static final DatabaseInfo DEFAULT_DATABASE_INFO = new InternalDatabaseInfo(null);
 
     private final String name;
 

driver/src/main/java/org/neo4j/driver/internal/svm/MicrometerSubstitutions.java

@@ -40,6 +40,7 @@ final class Target_org_neo4j_driver_internal_DriverFactory {
      * @return A metrics provider, never null
      */
     @Substitute
+    @SuppressWarnings("ProtectedMemberInFinalClass")
     protected static MetricsProvider getOrCreateMetricsProvider(Config config, Clock clock) {
         var metricsAdapter = config.metricsAdapter();
         if (metricsAdapter == null) {

driver/src/main/java/org/neo4j/driver/internal/types/InternalTypeSystem.java

@@ -50,7 +50,7 @@
  * @see Type
  */
 public class InternalTypeSystem implements TypeSystem {
-    public static InternalTypeSystem TYPE_SYSTEM = new InternalTypeSystem();
+    public static final InternalTypeSystem TYPE_SYSTEM = new InternalTypeSystem();
 
     private final TypeRepresentation anyType = constructType(ANY);
     private final TypeRepresentation booleanType = constructType(BOOLEAN);

driver/src/main/java/org/neo4j/driver/internal/util/Futures.java

@@ -226,8 +226,8 @@ public static <T> BiConsumer<T, Throwable> futureCompletingConsumer(CompletableF
     }
 
     private static class CompletionResult<T> {
-        T value;
-        Throwable error;
+        final T value;
+        final Throwable error;
 
         CompletionResult(T value, Throwable error) {
             this.value = value;

driver/src/main/java/org/neo4j/driver/internal/value/BooleanValue.java

@@ -26,8 +26,8 @@ private BooleanValue() {
         // do nothing
     }
 
-    public static BooleanValue TRUE = new TrueValue();
-    public static BooleanValue FALSE = new FalseValue();
+    public static final BooleanValue TRUE = new TrueValue();
+    public static final BooleanValue FALSE = new FalseValue();
 
     public static BooleanValue fromBoolean(boolean value) {
         return value ? TRUE : FALSE;