Tls connections throw ServiceUnavaliable after restart of server #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viceUnav when failed to establish connections
lutovich
reviewed
Jan 16, 2017
There was a problem hiding this comment.
@zhenlineo looks good. Pointed out one possible simplification.
| public class ServerKilledIT | ||
| { | ||
| @Rule | ||
| public TestNeo4j neo4j = new TestNeo4j(); | ||
|
|
||
| @Parameters(name = "{0} connections") | ||
| public static Collection<Object[]> data() { |
There was a problem hiding this comment.
Can we make this method return a collection of Config.EncryptionLevel? I think it'll make code simpler - no need for ignored testName constructor argument and flat list of Config.EncryptionLevel can be returned.
Changed to use encryption level to make the code easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug where tls connections are failed with ClientException, while plaintext connections are failed with ServiceUnav when server restart.
#302