Skip to content

Incorrect typing on RxResult #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snurby7 opened this issue Aug 30, 2020 · 1 comment · Fixed by #729
Closed

Incorrect typing on RxResult #610

snurby7 opened this issue Aug 30, 2020 · 1 comment · Fixed by #729

Comments

@snurby7
Copy link

snurby7 commented Aug 30, 2020

neo4j-javascript-driver/types/result-rx.d.ts

Line 28 in 938930f

summary(): Observable<ResultSummary>

Per the docs, this should be consume to match what is presented in the docs here. Summary type causes my query to fail on v4.1.1.

https://neo4j.com/docs/api/javascript-driver/4.1/class/src/result-rx.js~RxResult.html#instance-method-consume
@bigmontz bigmontz linked a pull request Apr 30, 2021 that will close this issue
Fix RxResult method mapping #729
Merged
@bigmontz
Copy link
Contributor

Thanks, @snurby7 . This issue will be fixed at 4.3

@bigmontz bigmontz mentioned this issue Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RxResult method mapping bigmontz/neo4j-javascript-driver
2 participants
@bigmontz @snurby7