Remove session.read/write_transaction

Author: robsdedude

CHANGELOG.md

@@ -57,6 +57,8 @@ See also https://github.com/neo4j/neo4j-python-driver/wiki for a full changelog.
 - Remove deprecated class `neo4j.Bookmark` in favor of `neo4j.Bookmarks`.
 - Remove deprecated class `session.last_bookmark()` in favor of `last_bookmarks()`.
 - Make undocumented classes `ResolvedAddress`, `ResolvedIPv4Address`, and `ResolvedIPv6Address` private.
+- Remove deprecated `session.read_transaction` and `session.write_transaction`.
+  Instead, use `session.execute_read` and  `session.execute_write` respectively.
 
 
 ## Version 5.28

src/neo4j/_async/work/session.py

@@ -26,13 +26,6 @@
 from ..._async_compat import async_sleep
 from ..._async_compat.util import AsyncUtil
 from ..._conf import SessionConfig
-
-
-if t.TYPE_CHECKING:
-    from typing_extensions import deprecated
-else:
-    from ..._meta import deprecated
-
 from ..._util import ContextBool
 from ..._work import Query
 from ...api import (
@@ -673,51 +666,6 @@ async def get_two_tx(tx):
             kwargs,
         )
 
-    # TODO: 6.0 - Remove this method
-    @deprecated("read_transaction has been renamed to execute_read")
-    @AsyncNonConcurrentMethodChecker._non_concurrent_method
-    async def read_transaction(
-        self,
-        transaction_function: t.Callable[
-            te.Concatenate[AsyncManagedTransaction, _P], t.Awaitable[_R]
-        ],
-        *args: _P.args,
-        **kwargs: _P.kwargs,
-    ) -> _R:
-        """
-        Execute a unit of work in a managed read transaction.
-
-        .. note::
-            This does not necessarily imply access control, see the session
-            configuration option :ref:`default-access-mode-ref`.
-
-        :param transaction_function: a function that takes a transaction as an
-            argument and does work with the transaction.
-            ``transaction_function(tx, *args, **kwargs)`` where ``tx`` is a
-            :class:`.AsyncManagedTransaction`.
-        :type transaction_function:
-            typing.Callable[[AsyncManagedTransaction, P], typing.Awaitable[R]]
-        :param args: additional arguments for the `transaction_function`
-        :type args: P
-        :param kwargs: key word arguments for the `transaction_function`
-        :type kwargs: P
-
-        :returns: a result as returned by the given unit of work
-        :rtype: R
-
-        :raises SessionError: if the session has been closed.
-
-        .. deprecated:: 5.0
-            Method was renamed to :meth:`.execute_read`.
-        """
-        return await self._run_transaction(
-            READ_ACCESS,
-            TelemetryAPI.TX_FUNC,
-            transaction_function,
-            args,
-            kwargs,
-        )
-
     @AsyncNonConcurrentMethodChecker._non_concurrent_method
     async def execute_write(
         self,
@@ -779,51 +727,6 @@ async def create_node_tx(tx, name):
             kwargs,
         )
 
-    # TODO: 6.0 - Remove this method
-    @deprecated("write_transaction has been renamed to execute_write")
-    @AsyncNonConcurrentMethodChecker._non_concurrent_method
-    async def write_transaction(
-        self,
-        transaction_function: t.Callable[
-            te.Concatenate[AsyncManagedTransaction, _P], t.Awaitable[_R]
-        ],
-        *args: _P.args,
-        **kwargs: _P.kwargs,
-    ) -> _R:
-        """
-        Execute a unit of work in a managed write transaction.
-
-        .. note::
-            This does not necessarily imply access control, see the session
-            configuration option :ref:`default-access-mode-ref`.
-
-        :param transaction_function: a function that takes a transaction as an
-            argument and does work with the transaction.
-            ``transaction_function(tx, *args, **kwargs)`` where ``tx`` is a
-            :class:`.AsyncManagedTransaction`.
-        :type transaction_function:
-            typing.Callable[[AsyncManagedTransaction, P], typing.Awaitable[R]]
-        :param args: additional arguments for the `transaction_function`
-        :type args: P
-        :param kwargs: key word arguments for the `transaction_function`
-        :type kwargs: P
-
-        :returns: a result as returned by the given unit of work
-        :rtype: R
-
-        :raises SessionError: if the session has been closed.
-
-        .. deprecated:: 5.0
-            Method was renamed to :meth:`.execute_write`.
-        """
-        return await self._run_transaction(
-            WRITE_ACCESS,
-            TelemetryAPI.TX_FUNC,
-            transaction_function,
-            args,
-            kwargs,
-        )
-
 
 def retry_delay_generator(initial_delay, multiplier, jitter_factor):
     delay = initial_delay