Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make feature introduced in version 3.0.6 toggleable #333

Open
xi-lef opened this issue Jun 20, 2023 · 3 comments · May be fixed by #349
Open

make feature introduced in version 3.0.6 toggleable #333

xi-lef opened this issue Jun 20, 2023 · 3 comments · May be fixed by #349

Comments

@xi-lef
Copy link

xi-lef commented Jun 20, 2023

Version 3.0.6 changed the behaviour of coc-snippets, as CHANGELOG.md says:

Avoid check and show context snippets in pum.

I cannot use coc-snippets with this feature, so I am using version 3.0.5, which is not ideal.
For me, I need snippets to be shown in the pum even if they have a context.

Is it possible to make this a feature you can toggle on and off in the config? I would really like that.

@chemzqm
Copy link
Member

chemzqm commented Sep 6, 2023

Problem is the check for context could be buggy and slow, do you want to always show them in completion menu?

@xi-lef
Copy link
Author

xi-lef commented Sep 6, 2023

I do not want to always show them. I would like it the way it was in version 3.0.5: just execute the context and if it is true, show the snippet in the completion menu. If context is buggy or slow, I think it is my own fault, and I should just fix that. But if someone does not want that at all, they could maybe toggle it off in the config.

@xi-lef
Copy link
Author

xi-lef commented Jan 27, 2024

I implemented it myself now, so if anyone else is interested, feel free to use my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants