Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime dependencies should not be under devDependencies #14

Open
neocotic opened this issue Mar 24, 2017 · 1 comment
Open

Runtime dependencies should not be under devDependencies #14

neocotic opened this issue Mar 24, 2017 · 1 comment
Labels
bug
Milestone
3.0.0

Comments

@neocotic
Copy link
Owner

Currently, since most consumers of this library will be using dist/yourls.js or dist/yourls.min.js this doesn't really matter as runtime dependencies are bundled with this library, but oopsy is under "devDependencies". This means that those importing YOURLS API as an ES6 module will be hitting issues as we haven't declared it properly.
@neocotic neocotic added the bug label Mar 24, 2017
@neocotic neocotic added this to the 3.0.0 milestone Mar 24, 2017
@neocotic neocotic mentioned this issue Mar 24, 2017
Open
4 tasks
@neocotic
Copy link
Owner Author

The fix for this was committed under faf6edf. I forgot to 🏷️ the commit, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@neocotic