-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config cleanup, part 3 #183
Comments
For server configs: If it is saved outside a world, it should edit default server config. And if inside world, it should save new server config into the world’s serverconfig folder. Dunno what the underlying architecture would be to support this use case |
A server config cannot be edited outside the world, as it is not loaded and is completely inaccessible. |
Hmm. That’s a bit annoying that you would need to make a world first to be able to edit default server configs through the config gui. I would like to see some sort of system that allows us to allow editing just the default file if exists outside of worlds. Just food for thought as I’m not personally a fan of making new world, edit default config in gui, delete world, make second world to have the values applied for worldgen and stuff |
(IMO it should also edit the world config by default, and have a checkbox/button (for the UI) or a booelan param (for the API) to set the global config too, as those are user defined settings when inside their world, and the dont necessarily expect to be editing the default global config, especially in the UI where they might not be aware of how config files actually work) EDIT: adding to this that this is only an issue for singleplayer setup (with multiple saves) where the user is even less likely to be aware of those internal mechanics |
Just remember that the user most likely does have no idea the config could even be made world-specific. Also, I'd expect them to expect to edit the config that currently is loaded and in effect, not another one. So creating a per-world silently in the background that isn't even the one that's active in the world they are in would be surprising. |
You could do it similar to how old NEI did its config. I think it had global by default and world-specific was accessed by changing which set of configs you wanted to edit. |
Something like that was my idea, just not on a per-value level as the config system can't do that. I would add a button to the top-most screen of any server config that would show if the config was global or per-world, and if it was the former, the button would become pressable and would write the current config out as a per-world config. Propper tooltips explaining this included. |
The following changes have been talked about:
Nothing has been decided yet. Discuss on Discord, brainstorming>config stuff, then document any decisions here.
The text was updated successfully, but these errors were encountered: