Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch methods in EquipmentModelProvider to be more mod compatible #1843

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

ApexModder
Copy link
Contributor

This PR patches 2 methods in EquipmentModelProvider to be more mod compatible, this is done by swapping out ResourceLocation.withDefaultNamespace with ResourceLocation.parse.

Fixes #1842

@ApexModder ApexModder added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 12, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 12, 2025

  • Publish PR to GitHub Packages

Last commit published: f0962faf47989b4e12d8e7e88c82974a3a8f6fe1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1843' // https://github.com/neoforged/NeoForge/pull/1843
        url 'https://prmaven.neoforged.net/NeoForge/pr1843'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1843.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1843
cd NeoForge-pr1843
curl -L https://prmaven.neoforged.net/NeoForge/pr1843/net/neoforged/neoforge/21.4.54-beta-pr-1843-pr-equipment-mod-compat/mdk-pr1843.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@sciwhiz12 sciwhiz12 added the bug A bug or error label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21.4] EquipmentModelProvider methods should be changed to be more modid compatible
3 participants