You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The old V2 extension (and perhaps the Firefox extension if I base that on V2) uses createObjectURL to download the blob. I'm not sure when/if the created URL (and therefore its referenced blob) will get garbage collected; documentation says "when the document is unloaded" but I'm not sure what that is in the case of this extension's background.js script.
I could explicitly call revokeObjectURL if needed, although not until I'm sure that it's unused/unreferenced. I guess that would be in the handleDownloadChanged callback in the same spot as clearing status and re-enabling the context menu.
It may be that the current garbage collecting behavior is fine though. Need to check.
The text was updated successfully, but these errors were encountered:
The old V2 extension (and perhaps the Firefox extension if I base that on V2) uses createObjectURL to download the blob. I'm not sure when/if the created URL (and therefore its referenced blob) will get garbage collected; documentation says "when the document is unloaded" but I'm not sure what that is in the case of this extension's background.js script.
I could explicitly call revokeObjectURL if needed, although not until I'm sure that it's unused/unreferenced. I guess that would be in the handleDownloadChanged callback in the same spot as clearing status and re-enabling the context menu.
It may be that the current garbage collecting behavior is fine though. Need to check.
The text was updated successfully, but these errors were encountered: