Commandes: Unit test refactor: Replace Thread.sleep by a .block and a .zip to fix a number of event and do a deterministic test

Author: neokeld

commandes/src/test/java/fr/duforat/demos/commandes/handler/ReactiveWebSocketIntegrationTest.java

@@ -12,6 +12,7 @@
 import org.springframework.web.reactive.socket.client.WebSocketClient;
 
 import fr.duforat.demos.commandes.CommandesApplication;
+import reactor.core.publisher.Flux;
 
 @SpringBootTest(classes = CommandesApplication.class)
 public class ReactiveWebSocketIntegrationTest {
@@ -21,9 +22,7 @@ public class ReactiveWebSocketIntegrationTest {
     @Test
     public void testNotificationsOnUpdates() throws Exception {
 
-    	long durationInterval = 800;
-        int countEmitedEvents = 2;
-        long margin = 900;
+        int emitedEventsNumber = 2;
         AtomicLong counter = new AtomicLong();
         URI uri = URI.create("ws://localhost:7000/event-emitter");
 
@@ -33,14 +32,13 @@ public void testNotificationsOnUpdates() throws Exception {
                 .receive()
                 .map(WebSocketMessage::getPayloadAsText)
                 .doOnNext(str -> counter.incrementAndGet())
+                .zipWith(Flux.range(1, emitedEventsNumber))
                 .then()
                 .log();
 
-        }).subscribe();
+        }).block();
 
-        Thread.sleep(countEmitedEvents * durationInterval + margin);
-
-        Assertions.assertThat(counter.get()).isEqualTo(countEmitedEvents);
+        Assertions.assertThat(counter.get()).isEqualTo(emitedEventsNumber);
     }
 
 }