Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Nan::MakeCallback usage to AsyncResource #419

Closed
kjvalencik opened this issue Aug 15, 2019 · 1 comment
Closed

Switch Nan::MakeCallback usage to AsyncResource #419

kjvalencik opened this issue Aug 15, 2019 · 1 comment
Labels
enhancement requires v8 c++

Comments

@kjvalencik
Copy link
Member

Nan::MakeCallback is deprecated and doesn't correctly handle domains. This may fix #418.

https://github.com/nodejs/nan/blob/master/doc/node_misc.md#nanmakecallback
@kjvalencik
Copy link
Member Author

Duplicates #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement requires v8 c++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjvalencik